modified automate_config.go #8341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for chef-automate processing.
|
YashviJain01
force-pushed
the
swatign/CHEF-3394
branch
from
5c8037f
to
66ad8be
Compare
swatiganesh
force-pushed
the
swatign/CHEF-3394
branch
from
66ad8be
to
764fe66
Compare
Signed-off-by: swatign <SwatiGanesh.Naik@Progress.com>
Signed-off-by: swatign <SwatiGanesh.Naik@Progress.com>
Signed-off-by: swatign <SwatiGanesh.Naik@Progress.com>
Signed-off-by: swatign <SwatiGanesh.Naik@Progress.com>
swatiganesh
force-pushed
the
swatign/CHEF-3394
branch
from
764fe66
to
7a846c6
Compare
Dmaddu
requested changes
Jan 24, 2024
| @@ -107,10 +108,29 @@ func PatchAutomateConfig(timeout int64, config *dc.AutomateConfig, writer cli.Fo | |||
| if config.Global.V1.Backups.Filesystem.Path.Value != "" && !isOSEnabled { | |||
| fmt.Println("Waiting till all the services comes in healthy state...") | |||
| backupScript := fmt.Sprintf(backupPathFix, strings.TrimSuffix(config.Global.V1.Backups.Filesystem.Path.Value, "/")) | |||
| _, err := exec.Command("/bin/sh", "-c", backupScript).Output() | |||
| if err != nil { | |||
| //fmt.Printf("backupScript: %v\n", backupScript) | |||
There was a problem hiding this comment.
please remove commented lines of code
Signed-off-by: swatign <SwatiGanesh.Naik@Progress.com>
|
SonarQube Quality Gate
|
Dmaddu
approved these changes
Jan 29, 2024
swatiganesh
added a commit
that referenced
this pull request
Apr 16, 2024
* modified automate_config.go Signed-off-by: swatign <SwatiGanesh.Naik@Progress.com> * checking backup gateway Signed-off-by: swatign <SwatiGanesh.Naik@Progress.com> * modified backup-gateway plan.sh Signed-off-by: swatign <SwatiGanesh.Naik@Progress.com> * modified backup-gateway Signed-off-by: swatign <SwatiGanesh.Naik@Progress.com> * removed commented lines Signed-off-by: swatign <SwatiGanesh.Naik@Progress.com> --------- Signed-off-by: swatign <SwatiGanesh.Naik@Progress.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description: What code changed, and why?
Changed syntax of backup script and added code in PatchAutomateConfig of automate_config.go and added core/curl pkg in plan.sh of backup-gateway
I've tested in Amazon Linux, Ubuntu, Red Hat Enterprise Linux, SUSE Linux Enterprise Server machines
⛓️ Related Resources
https://chefio.atlassian.net/jira/software/c/projects/CHEF/boards/482?assignee=712020%3Ad2c1e267-ff0f-4938-9184-e58d1eb78a2d&assignee=60746df1115da6006f1580da&selectedIssue=CHEF-3394
👍 Definition of Done
Changed syntax of backup script and added code in PatchAutomateConfig of automate_config.go and added core/curl pkg in plan.sh of backup-gateway
👟 How to Build and Test the Change
rebuild/components/backup-gateway/
rebuild/components/automate-gateway/
rebuild/components/automate-cli/
rebuild/components/automate-deployment/
✅ Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spellin any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
📷 Screenshots, if applicable
https://progresssoftware-my.sharepoint.com/:v:/g/personal/swatign_progress_com/EcLgs7TV9OhEpq3MKbsk5TEBBPYVCp1sFzlGlZU_4_q-6A?e=RLONEu
https://progresssoftware-my.sharepoint.com/:v:/g/personal/swatign_progress_com/ERU-Ki1uCKNPgaP108axKloBEue8c-CoPssjFH0VCNPyjg?e=Mf8StL
https://progresssoftware-my.sharepoint.com/:v:/g/personal/swatign_progress_com/EQmQEMCzU79JrF-PN-smVwkBa9cjzgU9Nn8ZcCQk3bVGOQ?e=eac8fN