Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backward compatibility #8491

Merged
merged 10 commits into from
Jul 22, 2024
Merged

backward compatibility #8491

merged 10 commits into from
Jul 22, 2024

Conversation

daveaugustus
Copy link
Contributor

πŸ”© Description: What code changed, and why?

⛓️ Related Resources

πŸ‘ Definition of Done

πŸ‘Ÿ How to Build and Test the Change

βœ… Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

πŸ“· Screenshots, if applicable

Signed-off-by: daveaugustus <pappu.kumar@progress.com>
Copy link

netlify bot commented Jul 22, 2024

πŸ‘· Deploy Preview for chef-automate processing.

Name Link
πŸ”¨ Latest commit 39b0f9f
πŸ” Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/669e575b5220dd00085834b9

daveaugustus added 3 commits July 22, 2024 13:05
Signed-off-by: daveaugustus <pappu.kumar@progress.com>
Signed-off-by: daveaugustus <pappu.kumar@progress.com>
Signed-off-by: daveaugustus <pappu.kumar@progress.com>
@daveaugustus daveaugustus requested a review from Dmaddu July 22, 2024 07:57
daveaugustus added 6 commits July 22, 2024 14:36
Signed-off-by: daveaugustus <pappu.kumar@progress.com>
Signed-off-by: daveaugustus <pappu.kumar@progress.com>
Signed-off-by: daveaugustus <pappu.kumar@progress.com>
UTC
Signed-off-by: daveaugustus <pappu.kumar@progress.com>
Signed-off-by: daveaugustus <pappu.kumar@progress.com>
Signed-off-by: daveaugustus <pappu.kumar@progress.com>

Quality Gate failed Quality Gate failed

Failed conditions
3 New issues
2.0% Coverage on New Code (required β‰₯ 80%)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@Dmaddu Dmaddu merged commit ce00764 into main Jul 22, 2024
10 of 13 checks passed
@Dmaddu Dmaddu deleted the ha_backward_compatibal branch July 22, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants