Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add profiling gems #120

Merged
merged 3 commits into from
Aug 18, 2020
Merged

Add profiling gems #120

merged 3 commits into from
Aug 18, 2020

Conversation

tas50
Copy link
Contributor

@tas50 tas50 commented Aug 10, 2020

These are useful for profiling the app

Signed-off-by: Tim Smith tsmith@chef.io

These are useful for profiling the app

Signed-off-by: Tim Smith <tsmith@chef.io>
@tas50 tas50 requested review from a team as code owners August 10, 2020 19:52
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
@tas50 tas50 force-pushed the profile branch 2 times, most recently from 05b4ba4 to 79954e8 Compare August 10, 2020 23:23
Copy link
Contributor

@phiggins phiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine, but is there value to having these always available vs adding them when profiling?

Copy link
Contributor

@tyler-ball tyler-ball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we update the appbundle line to exclude this group they won't be activated unless the user runs /opt/chef-workstation/embedded/bin/chef-cli

@tyler-ball tyler-ball merged commit 0a2782d into master Aug 18, 2020
@tyler-ball tyler-ball deleted the profile branch August 18, 2020 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants