Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use computed lock revision in policy installer output #211

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Use computed lock revision in policy installer output #211

merged 1 commit into from
Oct 25, 2022

Conversation

Annih
Copy link
Contributor

@Annih Annih commented Jun 19, 2022 •
edited
Loading

Otherwise the revision ID is computed from the original state.

Related Issue

#210

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • 🚫I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@Annih Annih requested review from a team as code owners June 19, 2022 21:10
@sonarcloud
Copy link

sonarcloud bot commented Jun 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Annih
Copy link
Contributor Author

Annih commented Jun 19, 2022

This is enough to fix the issue #210, however I just don't see how to add simple tests.
The existing tests are not covering the bug, see this comment

It seems to me that implementing a test covering the full integration with the cache and lock would be too complex for such a trivial fix.
Let me know if you have a simple idea to validate this.

@Annih Annih force-pushed the fix_210_partial_update branch 2 times, most recently from 34f41e8 to f4ddd81 Compare September 3, 2022 13:42
@sonarcloud
Copy link

sonarcloud bot commented Sep 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Annih
Copy link
Contributor Author

Annih commented Oct 7, 2022

Hello @sanjain-progress what can I do to get at least feedback on this PR?

@sanjain-progress
Copy link
Contributor

@Annih
PR looks good to me.

can you please pull the latest changes in this PR?
I want to see if CI / Coverage checks start running or not

@Annih
Use computed lock revision in policy installer output
12a9547 
Otherwise the revision ID is computed from the original state.

Signed-off-by: Baptiste Courtois <b.courtois@criteo.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Annih
Copy link
Contributor Author

Annih commented Oct 23, 2022

Done @sanjain-progress , it seems that the workflow started and completed successfully :D

@sanjain-progress sanjain-progress merged commit a8bf19b into chef:main Oct 25, 2022
@Annih Annih deleted the fix_210_partial_update branch October 25, 2022 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanjain-progress sanjain-progress sanjain-progress approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Annih @sanjain-progress