Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fish shell completions #159

Closed
gibbling opened this issue Feb 8, 2016 · 2 comments
Closed

Fish shell completions #159

gibbling opened this issue Feb 8, 2016 · 2 comments

Comments

@gibbling
Copy link

gibbling commented Feb 8, 2016

Setting eval (chef shell-init fish) results in the $GEM_ROOT, $GEM_PATH, $GEM_HOME env variables getting set correctly but all the completions and the function __fish_chef_no_command does not.

I am seeing this when setting it specifically for the terminal I have open as well as when set in my fish config.

chefdk - 0.10.0
fish - 2.2.0

@tyler-ball tyler-ball transferred this issue from chef-boneyard/chef-dk Nov 1, 2019
@tyler-ball
Copy link
Contributor

Thanks @gibbling - I run fish and confirmed that it does not correctly add the functions

@tas50
Copy link
Contributor

tas50 commented Mar 21, 2021

Confirmed this is still broken with the latest chef-cli

@tas50 tas50 transferred this issue from chef/chef-workstation Mar 21, 2021
tas50 added a commit that referenced this issue Mar 21, 2021
It looks like these never worked based on #159

Signed-off-by: Tim Smith <tsmith@chef.io>
tas50 added a commit that referenced this issue Mar 21, 2021
It looks like these never worked based on #159

Signed-off-by: Tim Smith <tsmith@chef.io>
tas50 added a commit that referenced this issue Mar 21, 2021
It looks like these never worked based on #159

Signed-off-by: Tim Smith <tsmith@chef.io>
nikhil2611 added a commit that referenced this issue Apr 13, 2021
author Nikhil Gupta <nikhilgupta2102@gmail.com> 1614250329 +0530
committer Nikhil Gupta <nikhilgupta2102@gmail.com> 1618343433 +0530

added the test cases

Signed-off-by: Nikhil Gupta <nikhilgupta2102@gmail.com>

added the test cases

Signed-off-by: Nikhil Gupta <nikhilgupta2102@gmail.com>

modified the test cases

Signed-off-by: Nikhil Gupta <nikhilgupta2102@gmail.com>

modified the test cases

Signed-off-by: Nikhil Gupta <nikhilgupta2102@gmail.com>

modified the test cases

Signed-off-by: Nikhil Gupta <nikhilgupta2102@gmail.com>

modified the test cases

Signed-off-by: Nikhil Gupta <nikhilgupta2102@gmail.com>

updated the test cases

Signed-off-by: Nikhil Gupta <nikhilgupta2102@gmail.com>

updated the test cases

Signed-off-by: Nikhil Gupta <nikhilgupta2102@gmail.com>

updated the test cases with meesage to check values

Signed-off-by: Nikhil Gupta <nikhilgupta2102@gmail.com>

added some puts

Signed-off-by: Nikhil Gupta <nikhilgupta2102@gmail.com>

included the .toml file change

Signed-off-by: Nikhil Gupta <nikhilgupta2102@gmail.com>

added some puts to debug

Signed-off-by: Nikhil Gupta <nikhilgupta2102@gmail.com>

making name of cookbook in metedata generic so user not worry about the name of the folder

Signed-off-by: Pranay Singh <i5singh.pranay@gmail.com>

updating test to take cookbook name in metadata.rb from file path

Signed-off-by: Pranay Singh <i5singh.pranay@gmail.com>

Bump version to 3.1.1 by Chef Expeditor

Obvious fix; these changes are the result of automation not creative thinking.

Update CHANGELOG.md to reflect the promotion of 3.1.1

Obvious fix; these changes are the result of automation not creative thinking.

Update links in generators

Avoid redirects

Signed-off-by: Tim Smith <tsmith@chef.io>

Bump version to 3.1.2 by Chef Expeditor

Obvious fix; these changes are the result of automation not creative thinking.

Remove yard / pry-stack_explorer gemfile deps

Remove deps we're not using and require a working Test Kitchen

Signed-off-by: Tim Smith <tsmith@chef.io>

Bump version to 3.1.3 by Chef Expeditor

Obvious fix; these changes are the result of automation not creative thinking.

Update CHANGELOG.md to reflect the promotion of 3.1.3

Obvious fix; these changes are the result of automation not creative thinking.

Update os_x? helper to be macos? and mark it private

No one should code to this helper.

Signed-off-by: Tim Smith <tsmith@chef.io>

Bump version to 3.1.4 by Chef Expeditor

Obvious fix; these changes are the result of automation not creative thinking.

Generate dokken configs with privileged: true

This is required to get systemd services to start and will result in
people being more successful out of the box.

Signed-off-by: Tim Smith <tsmith@chef.io>

Update lib/chef-cli/skeletons/code_generator/templates/default/kitchen_dokken.yml.erb

Signed-off-by: Tim Smith <tsmith@chef.io>

Co-authored-by: Lance Albertson <lance@osuosl.org>

Fix the fish autocompletes for the chef command

It looks like these never worked based on #159

Signed-off-by: Tim Smith <tsmith@chef.io>

Bump version to 3.1.5 by Chef Expeditor

Obvious fix; these changes are the result of automation not creative thinking.

Bump version to 3.1.6 by Chef Expeditor

Obvious fix; these changes are the result of automation not creative thinking.

Update CHANGELOG.md to reflect the promotion of 3.1.6

Obvious fix; these changes are the result of automation not creative thinking.

stop generating spec directory on chef generate cookbook

Signed-off-by: Nikhil Gupta <nikhilgupta2102@gmail.com>

updated the test cases

Signed-off-by: Nikhil Gupta <nikhilgupta2102@gmail.com>

updated the test cases

Signed-off-by: Nikhil Gupta <nikhilgupta2102@gmail.com>

updated the failed test cases

Signed-off-by: Nikhil Gupta <nikhilgupta2102@gmail.com>

corrected the indentation issues

Signed-off-by: Nikhil Gupta <nikhilgupta2102@gmail.com>

included the .toml file change

Signed-off-by: Nikhil Gupta <nikhilgupta2102@gmail.com>

included the .toml file change

Signed-off-by: Nikhil Gupta <nikhilgupta2102@gmail.com>

identation error

Signed-off-by: Nikhil Gupta <nikhilgupta2102@gmail.com>

updated the .toml file

Signed-off-by: Nikhil Gupta <nikhilgupta2102@gmail.com>

updated the .toml file

Signed-off-by: Nikhil Gupta <nikhilgupta2102@gmail.com>

Bump version to 4.0.0 by Chef Expeditor

Obvious fix; these changes are the result of automation not creative thinking.

Update CHANGELOG.md to reflect the promotion of 4.0.0

Obvious fix; these changes are the result of automation not creative thinking.

Merged master fixed conflict.

Merged master fixed conflict.

Signed-off-by: Nikhil Gupta <nikhilgupta2102@gmail.com>

puts statement to check result

Signed-off-by: Nikhil Gupta <nikhilgupta2102@gmail.com>

puts statement to check result

Signed-off-by: Nikhil Gupta <nikhilgupta2102@gmail.com>

puts statement to check result

Signed-off-by: Nikhil Gupta <nikhilgupta2102@gmail.com>

updated the test cases

Signed-off-by: Nikhil Gupta <nikhilgupta2102@gmail.com>

updated the test cases

Signed-off-by: Nikhil Gupta <nikhilgupta2102@gmail.com>

updated the test cases

Signed-off-by: Nikhil Gupta <nikhilgupta2102@gmail.com>

Updated the test cases

Signed-off-by: Nikhil Gupta <nikhilgupta2102@gmail.com>

Updated the test cases

Signed-off-by: Nikhil Gupta <nikhilgupta2102@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants