Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add constraint to ActiveSupport gem to use version lower than 7.1 #169

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

ahasunos
Copy link
Collaborator

@ahasunos ahasunos commented Oct 10, 2023

Description

The latest version of ActiveSupport i.e. [7.1.0](https://rubygems.org/gems/activesupport/versions/7.1.0) - October 05, 2023 (250 KB) has some issue with setting the default config to use its cache_format_version as 7.1.0 and picks 6.1 instead by default.

This leads to a deprecation warning when using ActiveSupport Cache in our Faraday connection. Hence, until the ActiveSupport gem has a stable release and the issue is fixed, we continue to use the 7.0.x versions of ActiveSupport in our library.

DEPRECATION WARNING: Support for `config.active_support.cache_format_version = 6.1` has been deprecated and will be removed in Rails 7.2.

Check the Rails upgrade guide at https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#new-activesupport-cache-serialization-format
for more information on how to upgrade.
 (called from get_connection at ../chef-licensing/components/ruby/lib/chef-licensing/restful_client/base.rb:134)
DEPRECATION WARNING: Support for `config.active_support.cache_format_version = 6.1` has been deprecated and will be removed in Rails 7.2.

Similar issue existed with 7.0.x - rails/rails#45293 which has been fixed.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@ahasunos ahasunos self-assigned this Oct 10, 2023
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
@ahasunos ahasunos force-pushed the ss/activesupport-7.1-deprecation-issue branch from 4da0fb0 to 182ac7d Compare October 10, 2023 10:15
@Vasu1105 Vasu1105 merged commit dba097e into main Oct 10, 2023
3 checks passed
@ahasunos ahasunos deleted the ss/activesupport-7.1-deprecation-issue branch October 11, 2023 06:30
@ahasunos
Copy link
Collaborator Author

ahasunos commented Nov 2, 2023

rails/rails#49892

Will remove the constraint in the next release (7.1.2) rails/rails#49804

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants