fix max elasticsearch memory #2155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timothy Ehlers <tehlers@expedia.com>
nvwls
reviewed
Oct 27, 2020
omnibus/files/private-chef-cookbooks/private-chef/libraries/elasticsearch.rb
Outdated
Show resolved
Hide resolved
Signed-off-by: Timothy Ehlers <tehlers@expedia.com>
tehlers320
force-pushed
the
max_memory_es
branch
2 times, most recently
from
152a128
to
1e8ab49
Compare
|
Added a unit test for this. |
Signed-off-by: Timothy Ehlers <tehlers@expedia.com>
tehlers320
force-pushed
the
max_memory_es
branch
from
1e8ab49
to
73bc68f
Compare
|
@tehlers320 This looks good. (edit: nvm, read the original bug report and it answered my question) |
stevendanna
approved these changes
Oct 28, 2020
nvwls
reviewed
Oct 28, 2020
omnibus/files/private-chef-cookbooks/private-chef/libraries/elasticsearch.rb
Outdated
Show resolved
Hide resolved
nvwls
reviewed
Oct 28, 2020
omnibus/files/private-chef-cookbooks/private-chef/libraries/elasticsearch.rb
Outdated
Show resolved
Hide resolved
Signed-off-by: Timothy Ehlers <tehlers@expedia.com>
PrajaktaPurohit
approved these changes
Oct 28, 2020
markan
approved these changes
Oct 31, 2020
|
Just FYI, this is good to merge but we are currently investigating a sqitch+perl issue in the build pipeline so are holding off on merging things until we resolve that. |
|
rebased and merged from #2159. Thank you for your contribution @tehlers320! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Timothy Ehlers tehlers@expedia.com
Description
reconfigure fails on big servers.
Issues Resolved
#2154
Check List
Aha! Link: https://chef.aha.io/features/SH-434