Add gem_tasks to Rakefile so you can do rake release
#98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| s.executables = %w( chef-vault ) | ||
|
|
||
| s.add_dependency 'chef', '>= 0.10.10' |
There was a problem hiding this comment.
I'm starting to question this dependency... If chef-vault is not in the omnibus gem repo then this causes chef, the gem, to be pulled down and installed even if omnibus chef is installed. This can cause multiple, and conflicting, copies of chef to be on a box. I think this dependency should be removed. Thoughts?
There was a problem hiding this comment.
I'm fine with removing the dependency, but I don't think we should do it in this pull request. This pull request is a patch-bump to add a convenience task for pushing new Chef-Vault gem versions.
Let' s keep the dependency for now. We need at least a minor version bump when we remove the Chef gem dependency.
Clean up gemspec file and add development dependencies Ignore Gemfile.lock
moserke
added a commit
that referenced
this pull request
Apr 5, 2014
Add gem_tasks to Rakefile so you can do `rake release`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up gemspec file and add development dependencies
Ignore Gemfile.lock