Fix scary search behavior on terms containing dash character

[amazon]

Currently, dash character is defined as non-word character and it results into following search oddities:

$ knife node create mysql -d -z
Created node[mysql]
$ knife node create mysql-slave -d -z
Created node[mysql-slave]
$ knife search node 'name:mysql' -a name -z
2 items found

mysql:
  name: mysql

mysql-slave:
  name: mysql-slave

$ knife search node 'name:mysql?slave' -a name -z
0 items found

$ knife search node 'name:mysql-?lave' -a name -z
1 items found

mysql-slave:
  name: mysql-slave

[chef-supermarket]

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.

GitHub Users Who Are Not Authorized To Contribute

The following GitHub users do not appear to have signed a CLA:

• @amazon

Please sign the CLA here.

[chef-supermarket]

Hi. Your friendly Curry bot here. Just letting you know that all commit authors have become authorized to contribute. I have added the "Signed CLA" label to this issue so it can easily be found in the future.

[lazyval]

@amazon it would be nice to see backing spec for new behaviour, but overall 👍

[sawanoboly]

I've tested this. It will solve #158 .

before patch.

$ knife node list
aaa.host
bbb-aaa.host

$ knife search node "name:aaa.host"
2 items found

after patch.

$ knife search node "name:aaa.host"
1 items found

[lamont-granquist]

👍

[thommay]

👍