Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only test master branch and PRs #184

Merged
merged 1 commit into from
Jan 14, 2016
Merged

Only test master branch and PRs #184

merged 1 commit into from
Jan 14, 2016

Conversation

danielsdeleo
Copy link
Contributor

No description provided.

@mwrock
Copy link
Member

mwrock commented Jan 14, 2016

👍

@jrunning
Copy link
Contributor

Just to clarify, PRs will still get tested? This just prevents PRs and their associated branches from being tested?

@thommay
Copy link
Contributor

thommay commented Jan 14, 2016

correct.

@tyler-ball
Copy link
Contributor

👍

1 similar comment
@thommay
Copy link
Contributor

thommay commented Jan 14, 2016

👍

@danielsdeleo
Copy link
Contributor Author

@jrunning when you make travis changes like this, they get applied to the PR you're submitting. So if you compare this to e.g., #183, you'll see this one just ran the tests once, but that other PR ran the tests against the branch and against the PR (i.e., it tested a hypothetical merge commit for that PR, which in this case was the same thing because the pull request is up to date).

@danielsdeleo danielsdeleo merged commit cf1bd23 into master Jan 14, 2016
@danielsdeleo danielsdeleo deleted the dont-double-test-pr branch January 14, 2016 16:59
@chef chef locked and limited conversation to collaborators Nov 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants