chef_client_config resource doesn't generate data_collector.url and data_collector.token properly in client.rb

[nrgetik]

Description

chef_client_config resource doesn't generate data_collector.url and data_collector.token properly in client.rb

Chef Version

Chef Client 17.9.52

Platform Version

Ubuntu 18.04.5 LTS

Replication Case

Make a resource like this

chef_client_config 'tweak client.rb' do
  chef_server_url 'https://api.chef.io/organizations/asdf_org'
  chef_license 'accept'
  data_collector_server_url 'https://chef-automate.test/data-collector/v0/'
  data_collector_token 'yDe3hNL-XIh_tcYsLgdVuOHe1nI='
end

Client Output

Your run will show

+data_collector.server_url https://chef-automate.test/data-collector/v0/
+data_collector.token yDe3hNL-XIh_tcYsLgdVuOHe1nI=

And your client.rb will have

data_collector.server_url https://chef-automate.test/data-collector/v0/
data_collector.token yDe3hNL-XIh_tcYsLgdVuOHe1nI=

And your next run will say

[2022-03-24T21:49:55+00:00] FATAL: Configuration error SyntaxError: /etc/chef/client.rb:7: unknown regexp options - chf
...llector.server_url https://chef-automate.test/data-collector...
...                          ^~~~~
/etc/chef/client.rb:8: syntax error, unexpected local variable or method, expecting end-of-input
data_collector.token yDe3hNL-XIh_tcYsLgdVuOHe1nI=
                     ^~~~~~~

[2022-03-24T21:49:55+00:00] FATAL: Aborting due to error in '/etc/chef/client.rb': /etc/chef/client.rb:7: unknown regexp options - chf
...llector.server_url https://chef-automate.test/data-collector...
...                          ^~~~~
/etc/chef/client.rb:8: syntax error, unexpected local variable or method, expecting end-of-input
data_collector.token yDe3hNL-XIh_tcYsLgdVuOHe1nI=
                     ^~~~~~~

And then you'll be distraught because you wanted to show someone something and instead it's totally broken

Stacktrace

[johnmccrae]

renders correctly with Chef 18.4.0