Updates for the chef_client_config resource #12732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…perly quote out the data_collector properties when writing those to the client.rb Signed-off-by: Davin Taddeo <davin@chef.io>
|
Davin, we took a PR for this exact scenario from the community. Are you familiar with a user whose account name is DecoyJoe? |
chef-davin
force-pushed
the
davin/chef_client_config_updates
branch
from
988861e
to
2dbcf1b
Compare
PrajaktaPurohit
approved these changes
Mar 30, 2022
PrajaktaPurohit
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request is for two fixes for the chef_client_config resource to update the template to properly write out the values for the datacollector parameters. They were not being properly quoted previously.
Related Issue
#12713 - chef_client_config resource doesn't generate data_collector.url and data_collector.token properly in client.rb
Types of changes
Checklist: