Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap: If password or key file are required we should tell the flags to do so #8481

Closed
tas50 opened this issue May 7, 2019 · 3 comments

Comments

@tas50
Copy link
Contributor

tas50 commented May 7, 2019

If you try to bootstrap a node using a username in the URI you will receive a train error instead of a friendly knife error. The user shouldn't see train errors since they don't need to know what handles the transport under the hood. Additionally if there are flags missing we should make sure to let people know what flags they can use so they don't have to hit help or the docs site on their own.

bundle exec knife bootstrap ssh://ubuntu@ec2-34-221-181-2.us-west-2.compute.amazonaws.com --channel unstable -N tim_test
Creating new client for tim_test
Creating new node for tim_test
Connecting to ec2-34-221-181-2.us-west-2.compute.amazonaws.com
ERROR: Train::ClientError: Your SSH Agent has no keys added, and you have not specified a password or a key file

Also: Knife call it an identity file vs. train calling it a key file, which further confuses the issue

@tas50 tas50 added the Status: Untriaged An issue that has yet to be triaged. label May 7, 2019
@kvivek1115
Copy link
Contributor

Address in #8856

@kvivek1115
Copy link
Contributor

Fixes #8856 merged in master

@lock
Copy link

lock bot commented Oct 25, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2019
@lamont-granquist lamont-granquist removed the Status: Untriaged An issue that has yet to be triaged. label Jun 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants