Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows functional tests in Buildkite constantly fail #9476

Closed
tas50 opened this issue Mar 10, 2020 · 4 comments · Fixed by #9908 or #9906
Closed

Windows functional tests in Buildkite constantly fail #9476

tas50 opened this issue Mar 10, 2020 · 4 comments · Fixed by #9908 or #9906
Assignees
Labels
Aspect: Testing Does the project have good coverage, and is CI working? Type: Chore non-critical maintenance of a project.

Comments

@tas50
Copy link
Contributor

tas50 commented Mar 10, 2020

Our windows functional tests are basically broken. They run on a shared system and fight each other / fail when they try to write / delete the same files. We need to get to a point where this job can reliably run and gets our tests green.

@tas50 tas50 added the Status: Untriaged An issue that has yet to be triaged. label Mar 10, 2020
@lamont-granquist
Copy link
Contributor

This may be related (similar container issues where we can't run our specs on containers) to why we have most of our testing disabled in the omnibus pipeline on internal Chef Software buildkite.

https://github.com/chef/chef/blob/master/omnibus/omnibus-test.ps1#L94-L97

We need integration, functional and unit testing working on windows there, and need to have the chocolatey testing enabled.

https://github.com/chef/chef/blob/master/omnibus/omnibus-test.sh#L160-L161

Similarly on *nix we need to have those tests re-enabled.

@lamont-granquist
Copy link
Contributor

We need to be running all unit, functional and integration tests in all test stages, and need to be running them as root, and that probably means NOT on any containers -- which is why I dumped that comment into this issue, because I suspect that containers are probably at least the first problem we will run into with re-enabling those tests.

@tas50 tas50 added Aspect: Testing Does the project have good coverage, and is CI working? Type: Chore non-critical maintenance of a project. and removed Status: Untriaged An issue that has yet to be triaged. labels Mar 30, 2020
@snapp snapp self-assigned this Apr 8, 2020
@snapp
Copy link
Contributor

snapp commented May 22, 2020

with the new win-2019 ami including ruby 2.6 + 2.7 we just needed to ensure we were using privileged single-use instances to allow chef 15 + 16 pipelines to avoid clashing

@lock
Copy link

lock bot commented Jun 24, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Aspect: Testing Does the project have good coverage, and is CI working? Type: Chore non-critical maintenance of a project.
Projects
None yet
3 participants