apt purges are not idempotent

[jaymzh]

Description

When apt does a purge, if any package in the list is installed, it tries to uninstall them all, cfengine2 style.

Chef Version

15.9.17

Platform Version

Ubuntu 18.04

Replication Case

unwanted = [
  'whoopsie',
  'rtkit',
  'speech-dispatcher',
  'speech-dispatcher-audio-plugins',
  'kerneloops-daemon',
  'puppetlabs-release-pc1',
  'puppet',
  'landscape-common',
  'landscape-client',
  'avahi-autoipd',
  'avahi-daemon',
]

package unwanted do
  action :purge
end

Client Output

---- Begin output of ["apt-get", "-q", "-y", "purge", "whoopsie", "rtkit", "speech-dispatcher", "speech-dispatcher-audio-plugins", "kerneloops", "puppetlabs-release-pc1", "puppet", "landscape-common", "landscape-client", "avahi-autoipd", "avahi-daemon"] ----
STDOUT: Reading package lists...
Building dependency tree...
Reading state information...
STDERR: E: Unable to locate package puppetlabs-release-pc1
---- End output of ["apt-get", "-q", "-y", "purge", "whoopsie", "rtkit", "speech-dispatcher", "speech-dispatcher-audio-plugins", "kerneloops", "puppetlabs-release-pc1", "puppet", "landscape-common", "landscape-client", "avahi-autoipd", "avahi-daemon"] ----
Ran ["apt-get", "-q", "-y", "purge", "whoopsie", "rtkit", "speech-dispatcher", "speech-dispatcher-audio-plugins", "kerneloops", "puppetlabs-release-pc1", "puppet", "landscape-common", "landscape-client", "avahi-autoipd", "avahi-daemon"] returned 100

In this case one of the packages (landscape-common) was there so it needed to be removed, however, it tried uninstalling all of them as you can see above. Turns out that one of those packages isn't on the repos and thus apt barfed.

# dpkg -l 'whoopsie' 'rtkit' 'speech-dispatcher' 'speech-dispatcher-audio-plugins' 'kerneloops-daemon' 'puppetlabs-release-pc1' 'puppet' 'landscape-common' 'landscape-client'
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name                                                                    Version                                  Architecture                             Description
+++-=======================================================================-========================================-========================================-===================================================================================================================================================
ii  landscape-common                                                        18.01-0ubuntu3.4                         amd64                                    Landscape administration system client - Common files
dpkg-query: no packages found matching whoopsie
dpkg-query: no packages found matching rtkit
dpkg-query: no packages found matching speech-dispatcher
dpkg-query: no packages found matching speech-dispatcher-audio-plugins
dpkg-query: no packages found matching kerneloops-daemon
dpkg-query: no packages found matching puppetlabs-release-pc1
dpkg-query: no packages found matching puppet
dpkg-query: no packages found matching landscape-client