Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace wget with curl in 'rake spellcheck' #12211

Merged
merged 3 commits into from
Oct 27, 2021
Merged

replace wget with curl in 'rake spellcheck' #12211

merged 3 commits into from
Oct 27, 2021

Conversation

rpunt
Copy link
Contributor

@rpunt rpunt commented Oct 26, 2021 •
edited

Description

rake spellcheck requires wget, but macOS does not install wget by default. Swap in curl, which is more-widely available by default.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@rpunt
spellcheck task requires wget; ensure it's installed
6b0ab0a 
Signed-off-by: Ryan Punt <ryan@mirum.org>
@rpunt rpunt requested review from a team as code owners October 26, 2021 03:03
lamont-granquist
lamont-granquist reviewed Oct 26, 2021
View reviewed changes
tasks/spellcheck.rb Outdated
wget_version.is_a?(String) || abort(<<~INSTALL_WGET)
wget is not installed
INSTALL_WGET
end

task :fetch_common do
sh "wget -q https://raw.githubusercontent.com/chef/chef_dictionary/master/chef.txt -O chef_dictionary.txt"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you switch this to curl since that tends to be more ubiquitous?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Complete, PR updated.

@rpunt
Swap wget for curl
4a799c8 
Signed off by: Ryan Punt <ryan@mirum.org>
@rpunt
missed a variable reference in 'dictionary missing' error
5b34298 
Signed off by: Ryan Punt <ryan@mirum.org>
@rpunt rpunt changed the title spellcheck task requires wget; ensure it's installed swap wget for curl in 'rake spellcheck' Oct 27, 2021
@rpunt rpunt changed the title swap wget for curl in 'rake spellcheck' replace wget with curl in 'rake spellcheck' Oct 27, 2021
@tas50 tas50 added Expeditor: Skip Habitat Used to skip built_in:trigger_habitat_package_build Expeditor: Skip Omnibus Used to skip built_in:trigger_omnibus_release_build labels Oct 27, 2021
@tas50 tas50 merged commit ede42c8 into chef:main Oct 27, 2021
@tas50
Copy link
Contributor

tas50 commented Oct 27, 2021

Thanks @rpunt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lamont-granquist lamont-granquist lamont-granquist left review comments

Assignees
No one assigned
Labels
Expeditor: Skip Habitat Used to skip built_in:trigger_habitat_package_build Expeditor: Skip Omnibus Used to skip built_in:trigger_omnibus_release_build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rpunt @tas50 @lamont-granquist