Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tests on fork by updating repository reference #12215

Merged
merged 2 commits into from
Oct 27, 2021

Conversation

jakauppila
Copy link
Contributor

Update chef/chef references to utilize the environment variable GITHUB_REPOSITORY so that builds complete successfully via forks on Github.

Signed-off-by: Jared Kauppila Jared.Kauppila@sentry.com

Description

Currently when you fork chef/chef and attempted to execute the Github actions, it attempts to pull down the source code from the git commit at chef/chef which obviously does not exist.

This change will reference the owner/repository defined via GITHUB_REPOSITORY in Github actions so that the tests can run successfully. If that environment variable does not exist, it will default to chef/chef

Successful checks in fork: https://github.com/sentryinsurance/chef/pull/3/checks

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

…source code during tests to enable forked builds

Signed-off-by: Jared Kauppila <Jared.Kauppila@sentry.com>
@jakauppila jakauppila requested review from a team as code owners October 26, 2021 19:16
kitchen-tests/kitchen.yml Outdated Show resolved Hide resolved
Signed-off-by: Jared Kauppila <Jared.Kauppila@sentry.com>
@tas50 tas50 added Expeditor: Skip Habitat Used to skip built_in:trigger_habitat_package_build Expeditor: Skip Omnibus Used to skip built_in:trigger_omnibus_release_build labels Oct 27, 2021
@tas50 tas50 merged commit d44ab3e into chef:main Oct 27, 2021
@tas50
Copy link
Contributor

tas50 commented Oct 27, 2021

Thanks @jakauppila

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Expeditor: Skip Habitat Used to skip built_in:trigger_habitat_package_build Expeditor: Skip Omnibus Used to skip built_in:trigger_omnibus_release_build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants