Fix attribute performance issues in node.read (Chef-17) #12743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
This makes it so that callers can call the deep merge cache more or less directly so that we're not hanging onto a weird Hash-of-ImmutableMashes structure. Care still needs to be taken to consider the fact that: - the deep merge cache may not be merged for a given keys since it is lazily created, so we need to hit the top level accessor once to make sure the key is merged before we access it. - the top-level "give me it all" case where the path is totally empty is still handled by doing a manual deep merge of everything. Once that is done we can call APIs like read/read!/exist? directly on the ImmutableMash and have fewer edge cases to deal with. This has the same perf speedup that the prior approach does and keeps attribute mangling down to 1% of my runtime on my own cookbooks Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #12742