Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chef-17] backport Bump deps for net-ssh 7.x for RHEL 9 and Ubuntu 22.04 ssh #13332

Merged
merged 14 commits into from Feb 28, 2023
Merged

[chef-17] backport Bump deps for net-ssh 7.x for RHEL 9 and Ubuntu 22.04 ssh #13332

merged 14 commits into from Feb 28, 2023

Conversation

Stromweld
Copy link
Contributor

@Stromweld Stromweld commented Nov 8, 2022 •
edited

Description

Backport of bump deps for net-ssh 7.x for RHEL 9 and Ubuntu 22.04 ssh new algorithms support, update chef gemfile.lock with bundler update

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@Stromweld Stromweld requested review from a team as code owners November 8, 2022 01:05
@Stromweld Stromweld marked this pull request as draft November 8, 2022 01:05
@Stromweld Stromweld changed the title update dep for net-ssh 7 support [chef-17] backport update deps for net-ssh 7 support Nov 8, 2022
@Stromweld
update gem deps for net-ssh 7.x
30bf5c5 
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@Stromweld Stromweld changed the title [chef-17] backport update deps for net-ssh 7 support [chef-17] backport Bump deps for net-ssh 7.x for RHEL 9 and Ubuntu 22.04 ssh Nov 8, 2022
@Stromweld
fix badssl cert test
f2c1962 
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@Stromweld Stromweld changed the title [chef-17] backport Bump deps for net-ssh 7.x for RHEL 9 and Ubuntu 22.04 ssh [chef-17] backport Bump deps for net-ssh 7.x for RHEL 9 and Ubuntu 22.04 ssh and badssl self signed cert test Nov 8, 2022
@Stromweld Stromweld marked this pull request as ready for review November 8, 2022 01:47
@jaymzh jaymzh mentioned this pull request Nov 8, 2022
Closed
@Stromweld
bump train-core for net-ssh 7.x support
bda05d4 
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@Stromweld
update train-core dep versions
b31481f 
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@Stromweld Stromweld mentioned this pull request Nov 8, 2022
Open
@jaymzh jaymzh closed this Nov 22, 2022
@jaymzh jaymzh reopened this Nov 22, 2022
@Stromweld
update kitchen tests to use chef-17 from stable channel
5ed5ef4 
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@Stromweld
updated checkout to v3
145a846 
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@Stromweld
updated inspec and force buildkite to use chef-17 branch
c375f26 
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@Stromweld
update inspec
98855a7 
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@Stromweld
fix branch
7c8e021 
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@Stromweld
Copy link
Contributor Author

Stromweld commented Nov 23, 2022 •
edited

@jaymzh @tpowell-progress @PrajaktaPurohit @johnmccrae This PR has balooned a little into fixing pipelines for chef-17 branch. I almost have them fixed. I'm not sure what is causing the unit test for gems from non api website spec to fail. The other windows failures are around habitat and failure to find chef-utils 17.10.26 gem. Do you guys have any insights into how to fix these?

@tpowell-progress
Copy link
Contributor

Let's put this near the top of the priority for Chef 17 merges

@Stromweld
revert pipeline fixes, moved to another PR
56430b9 
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@Stromweld Stromweld changed the title [chef-17] backport Bump deps for net-ssh 7.x for RHEL 9 and Ubuntu 22.04 ssh and badssl self signed cert test [chef-17] backport Bump deps for net-ssh 7.x for RHEL 9 and Ubuntu 22.04 ssh Dec 2, 2022
@Stromweld
Copy link
Contributor Author

Reverted pipeline fixes and moved them to a new PR #13399

@Stromweld
revert omnibus gemfile.lock and update gems for chef-client
fdae91b 
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@Stromweld
merge latest changes in chef-17 branch
37ba19e 
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Dec 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@acrewdson
Copy link

acrewdson commented Feb 3, 2023 •
edited

@Stromweld thank you for this PR

@tpowell-progress can I ask if there's a possibliity this will be merged soon? the net-ssh dep conflict is causing major problems for folks on chef/knife 17 🙏

@Stromweld
rebase
2b92222 
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Feb 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tpowell-progress tpowell-progress merged commit d72df71 into chef:chef-17 Feb 28, 2023
@Stromweld Stromweld deleted the patch-2 branch February 28, 2023 20:59
johnmccrae pushed a commit that referenced this pull request Feb 28, 2023
@Stromweld @johnmccrae
[chef-17] backport Bump deps for net-ssh 7.x for RHEL 9 and Ubuntu 22…
27ffc47 
….04 ssh (#13332)

* update dep for net-ssh 7 support

* update gem deps for net-ssh 7.x

Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaymzh jaymzh jaymzh approved these changes

@tpowell-progress tpowell-progress tpowell-progress approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Stromweld @tpowell-progress @acrewdson @jaymzh