New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Gem versions - specifically updating Chef for omnibus #13391
Conversation
Signed-off-by: John <john.mccrae@progress.com>
Signed-off-by: John McCrae <john.mccrae@progress.com>
🤔 it looks clean enough, but can we redo this without the big merge commit up front? |
Do we have an adhoc build testing this? If not, can we run an adhoc build please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get a description here of all the things we're changing and why? We spent about 10 minutes in the PR Review meeting digging around in the rest-client/rest-client PRs and this one and still can't quite piece this all together enough to give a meaningful review. Thanks!
Signed-off-by: John <john.mccrae@progress.com>
Signed-off-by: John <john.mccrae@progress.com>
Signed-off-by: John <john.mccrae@progress.com>
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, much cleaner. Let’s make sure to squash and merge at the end
Could we paste the passing adhoc builds before merging? |
Here's the relevant AdHoc build - everything passes except the enterprise linux pieces which are failing for everything right now |
Signed-off-by: John john.mccrae@progress.com
Updating the chef version in Omnibus.
Description
Related Issue
Types of changes
Checklist: