Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Gem versions - specifically updating Chef for omnibus #13391

Merged
merged 6 commits into from Dec 1, 2022

Conversation

johnmccrae
Copy link
Contributor

Signed-off-by: John john.mccrae@progress.com

Updating the chef version in Omnibus.

Description

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

Signed-off-by: John <john.mccrae@progress.com>
@johnmccrae johnmccrae requested review from a team as code owners November 28, 2022 15:25
@tpowell-progress
Copy link
Contributor

🤔 it looks clean enough, but can we redo this without the big merge commit up front?

@neha-p6
Copy link
Collaborator

neha-p6 commented Nov 29, 2022

Do we have an adhoc build testing this? If not, can we run an adhoc build please?

Copy link
Collaborator

@jaymzh jaymzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get a description here of all the things we're changing and why? We spent about 10 minutes in the PR Review meeting digging around in the rest-client/rest-client PRs and this one and still can't quite piece this all together enough to give a meaningful review. Thanks!

Gemfile.lock Outdated Show resolved Hide resolved
Signed-off-by: John <john.mccrae@progress.com>
Signed-off-by: John <john.mccrae@progress.com>
Signed-off-by: John <john.mccrae@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Nov 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@Stromweld Stromweld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tpowell-progress tpowell-progress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, much cleaner. Let’s make sure to squash and merge at the end

@PrajaktaPurohit
Copy link
Contributor

PrajaktaPurohit commented Nov 30, 2022

Could we paste the passing adhoc builds before merging?

@johnmccrae
Copy link
Contributor Author

Here's the relevant AdHoc build - everything passes except the enterprise linux pieces which are failing for everything right now
https://buildkite.com/chef/chef-chef-main-omnibus-adhoc/builds/1760

@johnmccrae johnmccrae merged commit b65b3e7 into main Dec 1, 2022
@johnmccrae johnmccrae deleted the jfm/chef18_version branch December 1, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants