Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ulimits): additional ulimit options #13394

Merged
merged 2 commits into from Nov 16, 2023
Merged

feat(ulimits): additional ulimit options #13394

merged 2 commits into from Nov 16, 2023

Conversation

chrisminton
Copy link
Contributor

@chrisminton chrisminton commented Nov 30, 2022 •
edited

Description

  • add as, cpu, maxlogins, msgqueue, rss, sigpending options to the user_ulimit resource

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@chrisminton chrisminton requested review from a team as code owners November 30, 2022 14:56
@github-actions github-actions bot added the documentation How do we use this project? label Nov 30, 2022
@sonarcloud
Copy link

sonarcloud bot commented Nov 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@chrisminton chrisminton force-pushed the ulimit-options branch 3 times, most recently from 3176d1c to 2dca8ad Compare January 11, 2023 12:30
@johnmccrae
Copy link
Contributor

Can you add some tests in for these new options please?

@chrisminton
Copy link
Contributor Author

Hi @johnmccrae there are additions for the kitchen-tests section - this is currently the only place that ulimit options are being interrogated. Is there something you'd like me to add?

@tpowell-progress
Copy link
Contributor

tpowell-progress commented Jan 31, 2023 •
edited

Hi @johnmccrae there are additions for the kitchen-tests section - this is currently the only place that ulimit options are being interrogated. Is there something you'd like me to add?

@chrisminton Thanks for pointing those out. I think we're good with kitchen tests, but see notes for additional cases/fields.

jaymzh
jaymzh requested changes Jan 31, 2023
View reviewed changes
Copy link
Collaborator

@jaymzh jaymzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small bug.

lib/chef/resource/user_ulimit.rb Show resolved Hide resolved
@tpowell-progress tpowell-progress self-assigned this Jan 31, 2023
@tpowell-progress tpowell-progress added the Status: Waiting on Contributor A pull request that has unresolved requested actions from the author. label Jan 31, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@johnmccrae
Copy link
Contributor

@chrisminton Can you add the test that Phil requested?

@tpowell-progress
Copy link
Contributor

@chrisminton Looks like the Buildkite build is broken due to an old configuration file. Can you rebase on main, please?

@chrisminton
feat(ulimits): additional ulimit options
f552630 
- add as, cpu, maxlogins, msgqueue, rss, sigpending

Signed-off-by: Chris Minton <chris.minton@sainsburys.co.uk>
@chrisminton
ci(ulimit): add works to cspell exceptions
54c0872 
Signed-off-by: Chris Minton <chris.minton@sainsburys.co.uk>
@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

@tpowell-progress tpowell-progress added Focus: Community PR Review and removed Status: Waiting on Contributor A pull request that has unresolved requested actions from the author. labels Nov 14, 2023
@tpowell-progress
Copy link
Contributor

Approving workflows and tagging for community PR review.

@tpowell-progress tpowell-progress merged commit c5b44cd into chef:main Nov 16, 2023
19 of 31 checks passed
@chrisminton chrisminton deleted the ulimit-options branch November 16, 2023 09:11
@IanMadd IanMadd mentioned this pull request Jan 25, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaymzh jaymzh jaymzh approved these changes

@Daemonali Daemonali Daemonali approved these changes

@tpowell-progress tpowell-progress tpowell-progress approved these changes

Assignees

@tpowell-progress tpowell-progress

Labels
documentation How do we use this project? Focus: Community PR Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@chrisminton @johnmccrae @tpowell-progress @jaymzh @Daemonali