Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting the habitat pipeline issue for Windows #13440

Merged
merged 2 commits into from Dec 16, 2022

Conversation

johnmccrae
Copy link
Contributor

@johnmccrae johnmccrae commented Dec 14, 2022

Signed-off-by: John john.mccrae@progress.com

Description

The habitat-test.yml file was calling PowerShell command directly. This is hugely problematic since things like the $env variable weren't respected and that resulted in errors; for example calling $env:path would result in an error similar to :path is not recognized notice that the $env variable was chopped. In total this resulted in improper and incomplete execution. This update fixes that by moving the offending code to a distinct .ps1 file and calling on that; which does work.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

Signed-off-by: John <john.mccrae@progress.com>
… from yml files is problematic.

Signed-off-by: John <john.mccrae@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Dec 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@johnmccrae
Copy link
Contributor Author

Failing tests are known and being resolved elsewhere

@johnmccrae johnmccrae merged commit 349db91 into main Dec 16, 2022
@johnmccrae johnmccrae deleted the jfm/chef18_habitat_test branch December 16, 2022 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants