Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use the chef_dictionary directly. #13467

Merged
merged 1 commit into from Feb 28, 2023
Merged

chore: Use the chef_dictionary directly. #13467

merged 1 commit into from Feb 28, 2023

Conversation

Jason3S
Copy link
Contributor

@Jason3S Jason3S commented Dec 30, 2022

cspell and cspell-action now support fetching remote dictionaries.

Description

In order to spell check the repository, the shared chef_dictionary has to be downloaded. This change will have cspell download the dictionary instead.

Note: I am adding Chef to cspell integration tests to ensure that changes to cspell don't break spell checking the Chef repository when I hit a error because chef_dictionary.txt was missing.

Related Issue

Types of changes

  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

Signed-off-by: Jason Dent jason@steetsidesoftware.nl

@Jason3S Jason3S requested review from a team as code owners December 30, 2022 15:01
cspell.json Outdated Show resolved Hide resolved
.github/workflows/lint.yml Outdated Show resolved Hide resolved
@tpowell-progress tpowell-progress added the Status: Waiting on Contributor A pull request that has unresolved requested actions from the author. label Jan 10, 2023
`cspell` and `cspell-action` now support fetching remote dictionaries.

Note: the file format `version` is now "0.2".

Signed-off-by: Jason Dent <jason@steetsidesoftware.nl>
@sonarcloud
Copy link

sonarcloud bot commented Jan 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tpowell-progress tpowell-progress merged commit 4f0c312 into chef:main Feb 28, 2023
@Jason3S Jason3S deleted the patch-1 branch March 1, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Waiting on Contributor A pull request that has unresolved requested actions from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants