Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example of bash resource doubled escape characters #13509

Merged
merged 3 commits into from Jan 24, 2023

Conversation

sean-horn
Copy link
Contributor

Description

Let's show an example of doubled escape characters.

The chef-client bash interpreter gets one, and find gets one.

Signed-off-by: Sean Horn sean_horn@opscode.com

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

Let's show an example of doubled escape characters.

The chef-client bash interpreter gets one, and find gets one.

Signed-off-by: Sean Horn <sean_horn@opscode.com>
@sean-horn sean-horn requested review from a team as code owners January 17, 2023 17:55
@github-actions github-actions bot added the documentation How do we use this project? label Jan 17, 2023
lib/chef/resource/bash.rb Outdated Show resolved Hide resolved
Copy link
Contributor

@tpowell-progress tpowell-progress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sean-horn Please resolve trailing whitespace linting errors and Ian's suggestion and we can work on getting this merged in.

@tpowell-progress tpowell-progress self-assigned this Jan 17, 2023
@tpowell-progress tpowell-progress added the Status: Waiting on Contributor A pull request that has unresolved requested actions from the author. label Jan 19, 2023
Co-authored-by: Ian Maddaus <IanMadd@users.noreply.github.com>
@sean-horn
Copy link
Contributor Author

sean-horn commented Jan 24, 2023

@tpowell-progress Done. I have adopted @IanMadd 's suggestion. And cleaned up trailing whitespace

Clean up trailing whitespace

Signed-off-by: Sean Horn <sean_horn@opscode.com>
@sean-horn sean-horn changed the title Example of bash recource doubled escape characters Example of bash resource doubled escape characters Jan 24, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tpowell-progress tpowell-progress removed the Status: Waiting on Contributor A pull request that has unresolved requested actions from the author. label Jan 24, 2023
@tpowell-progress tpowell-progress merged commit c959be8 into chef:main Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation How do we use this project?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants