Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix adhoc pipelines and centos 6 omnibus test #13530

Merged
merged 4 commits into from Feb 2, 2023
Merged

fix adhoc pipelines and centos 6 omnibus test #13530

merged 4 commits into from Feb 2, 2023

Conversation

evanahlberg
Copy link
Contributor

@evanahlberg evanahlberg commented Jan 25, 2023 •
edited

Signed-off-by: Evan Ahlberg evanahlberg@gmail.com

Description

Make the pre-command run on the new validate adhoc/release pipelines.
Revert change to omnibus-test.sh to fix failing centos 6 test changed in this PR:
#13489

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@evanahlberg
fix adhoc pipelines and centos 6 omnibus test
605937d 
Signed-off-by: Evan Ahlberg <evanahlberg@gmail.com>
@evanahlberg evanahlberg marked this pull request as ready for review January 25, 2023 18:55
@evanahlberg evanahlberg requested review from a team as code owners January 25, 2023 18:55
@evanahlberg
run on all validate/ pipelines
80127ea 
Signed-off-by: Evan Ahlberg <evanahlberg@gmail.com>
@evanahlberg
fix aws credentials on windows for canary
59ff7c1 
Signed-off-by: Evan Ahlberg <evanahlberg@gmail.com>
@gcs-devel gcs-devel mentioned this pull request Jan 30, 2023
Closed
10 tasks
tpowell-progress
tpowell-progress requested changes Jan 31, 2023
View reviewed changes
omnibus/omnibus-test.sh Outdated Show resolved Hide resolved
jaymzh
jaymzh requested changes Jan 31, 2023
View reviewed changes
omnibus/omnibus-test.sh Outdated Show resolved Hide resolved
@evanahlberg
remove commented out code
e3be6a7 
Signed-off-by: Evan Ahlberg <evanahlberg@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Jan 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@tpowell-progress tpowell-progress merged commit 625558f into main Feb 2, 2023
@tpowell-progress tpowell-progress deleted the fix-adhoc-and-centos-6 branch February 2, 2023 19:54
@tpowell-progress
Copy link
Contributor

Bypassed protections due to concerns being addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpowell-progress tpowell-progress tpowell-progress approved these changes

@jaymzh jaymzh Awaiting requested review from jaymzh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@evanahlberg @tpowell-progress @jaymzh