Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIx kitchen test failures in windows boxes due to dependency issue in proxifier #13644

Merged
merged 1 commit into from Mar 21, 2023

Conversation

neha-p6
Copy link
Collaborator

@neha-p6 neha-p6 commented Mar 21, 2023

Description

Kitchen tests on windows fail when installing gems with error:

1 gem installed
  Successfully built RubyGem
  Name: rest-client
  Version: 2.1.0
  File: rest-client-2.1.0.gem
Successfully installed rest-client-2.1.0
1 gem installed
WARNING:  licenses is empty, but is recommended.  Use a license identifier from
http://spdx.org/licenses or 'Nonstandard' for a nonstandard license.
WARNING:  See https://guides.rubygems.org/specification-reference/ for help
  Successfully built RubyGem
  Name: proxifier
  Version: 1.0.3
  File: proxifier-1.0.3.gem
ERROR:  Error installing proxifier-1.0.3.gem:
	"pirb" from proxifier conflicts with installed executable from proxifier2
post-bundle-install.rb:27:in `block (2 levels) in <main>': gem install failed (RuntimeError)
	from post-bundle-install.rb:25:in `chdir'
	from post-bundle-install.rb:25:in `block in <main>'
	from post-bundle-install.rb:11:in `each'
	from post-bundle-install.rb:11:in `<main>'
fixing bundle installed gems in C:/opscode/chef/embedded/lib/ruby/gems/3.1.0
re-installing ohai...
re-installing ohai...
re-installing rest-client...
re-installing proxifier...

(Ref https://github.com/chef/chef/actions/runs/4477841478/jobs/7869877395?pr=13643#step:5:65)

We used to pull proxifier from git repo but now it is getting pulled from rubygems itself.
But somehow github kitchen test windows boxes still have previously git downloaded entry for proxifier (the boxes are not cleaned up?) due to which post-bundle-install.rb tries to reinstall it resulting in dependency issues between proxifier and proxifier2.
The script post-bundle-install is specifically doing the job of re-installing gems which are pulled from git repos.
The bundler/gems directory on those windows boxes seems to still have proxifier which was downloaded from git repo, so we would just skip it from reinstalling.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

…from rubygems itself. But somehow github kitchen test windows boxes still have previously downloaded (they are not cleaned up?) due to which post-bundle-install.rb tries to reinstall the git repo linked proxifier gem resulting in dependency issues between proxifier and proxifier2

Signed-off-by: Neha Pansare <neha.pansare@progress.com>
@neha-p6 neha-p6 requested review from a team as code owners March 21, 2023 11:06
@sonarcloud
Copy link

sonarcloud bot commented Mar 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@neha-p6 neha-p6 merged commit 16474d8 into main Mar 21, 2023
27 of 28 checks passed
@neha-p6 neha-p6 deleted the neha-p6/fix_windows_kitchen_proxifier branch March 21, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants