Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues in habitat/test pipeline #13649

Merged
merged 1 commit into from Mar 27, 2023

Conversation

neha-p6
Copy link
Collaborator

@neha-p6 neha-p6 commented Mar 27, 2023

Description

This PR fixes following issues:

  1. Fix pre-hook command failures in habitat/test and mac_universal_package pipelines which are triggered on a PR merge
  2. The script for habitat/test pipeline was making use of hardcoded artifacts. This is fixed
  3. Add error handling for habitat testers on windows platform, currently builds show green even if it has failed
  4. Fix habitat tester on windows platform by passing artifact as parameter

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@neha-p6 neha-p6 requested review from a team as code owners March 27, 2023 09:46
…elines, remove hardcoded habitat artifacts used in hab/test

pipelines

Signed-off-by: Neha Pansare <neha.pansare@progress.com>

* Fix habitat testers on windows platforms by passing artifact as parameter add error handling to the windows script

Signed-off-by: Neha Pansare <neha.pansare@progress.com>
@neha-p6 neha-p6 force-pushed the neha-p6/fix_habitat_test_pipeline_chef18 branch from 722ce68 to d7aa065 Compare March 27, 2023 10:44
@sonarcloud
Copy link

sonarcloud bot commented Mar 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@neha-p6
Copy link
Collaborator Author

neha-p6 commented Mar 27, 2023

@johnmccrae johnmccrae merged commit c4cfa3b into main Mar 27, 2023
29 checks passed
@johnmccrae johnmccrae deleted the neha-p6/fix_habitat_test_pipeline_chef18 branch March 27, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants