Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sean simmons progress/bugfix/build docker image #13657

Merged
merged 53 commits into from Mar 30, 2023
Merged

Sean simmons progress/bugfix/build docker image #13657

merged 53 commits into from Mar 30, 2023

Conversation

sean-simmons-progress
Copy link
Contributor

@sean-simmons-progress sean-simmons-progress commented Mar 29, 2023 •
edited

This is addressing many things. Its now producing a ARM(arrch64) binary and uploading that to our artifactory instance. We are also now uploading the .msi packages for the windows instances to artifactory.

Description

not all the supported OS's we are building were producing a binary. That is now solved. We also solved the docker verify private pipelines are working.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@sean-simmons-progress
testing output on the vars for docker build
00d71f7 
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@sean-simmons-progress
adding correct version
7069e7e 
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@sean-simmons-progress
found an error on the omnibus_chef_build.sh and .ps1
e4971ad 
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@sean-simmons-progress
adding arm platform
094debe 
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@sean-simmons-progress
adding arm platform
11fdfb5 
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@sean-simmons-progress
adding arm platform
b0ea621 
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@sean-simmons-progress
adding arm platform
58185cc 
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@sean-simmons-progress
adding arm64 platforms to this script
f87b4a5 
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@sean-simmons-progress
adding arm64 platforms to this script
d1ffaf2 
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@sean-simmons-progress
adding arm64 platforms to this script
b90db55 
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@sean-simmons-progress
binding var
a0c13d7 
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@sean-simmons-progress
binding var
93866b8 
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@sean-simmons-progress
rename
00316af 
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@sean-simmons-progress
adding debug
2a8ac14 
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@sean-simmons-progress
adding arm in the name
db05b1f 
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@sean-simmons-progress
adding arm test portion
c38a663 
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@sean-simmons-progress
adding arm test portion
820d38e 
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@sean-simmons-progress
adding arm test portion
c55ea36 
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@sean-simmons-progress
adding arm test portion
c125d89 
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@sean-simmons-progress
synatx issue
c98bd65 
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@sean-simmons-progress
changing build platform on sles15 to 12, as we only build 12
ab378ef 
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@sean-simmons-progress
changing build platform on sles15 to 12, as we only build 12
06b6f03 
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@sean-simmons-progress
attempting hard code for sles-15-arm
cfa0d9a 
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@sean-simmons-progress
testing windows builds, and undoing the sles 15 arm
c461497 
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@sean-simmons-progress
testing windows builds
206af32 
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@sean-simmons-progress
reverting windows settings
2c7eaf4 
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@sean-simmons-progress
chagning file since its adhoc build for testing
080c138 
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@sean-simmons-progress
chagning file since its adhoc build for testing
c870bd9 
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@sean-simmons-progress
chagning file since its adhoc build for testing
3f46f1b 
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@sean-simmons-progress
removing arm sles 15 for now as it cant find teh binary to download
88c7690 
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@sean-simmons-progress
syntax
82dcc8a 
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@sean-simmons-progress
testing changes here through the loop and the pipeline
8c645c5 
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@sean-simmons-progress
fixing the docker error on :arm
ca53b48 
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@sean-simmons-progress
fixing line 111
ac7cc69 
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@sean-simmons-progress
fixing line 111
755c9f2 
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@sean-simmons-progress
removing the label for now
7ff1154 
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@sean-simmons-progress
adding the label
cb3224e 
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@sean-simmons-progress
removing old code and cleaing up test emoji
cfdb5b3 
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@sean-simmons-progress
syntax on the label for testing
44a7707 
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@sean-simmons-progress
adding the same conditional on the testing portion of this build
2d53e9c 
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@sean-simmons-progress
removing for now
895b5e3 
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@sean-simmons-progress sean-simmons-progress marked this pull request as ready for review March 30, 2023 01:14
@sean-simmons-progress sean-simmons-progress marked this pull request as draft March 30, 2023 11:09
@sean-simmons-progress
the upload filter needs to match aarch64
a7319cc 
testing this build

Signed-off-by: Sean Simmons <ssimmons@progress.com>
@sean-simmons-progress
Merge branch 'main' of github.com:chef/chef into sean-simmons-progres…
9041676 
…s/bugfix/build-docker-image syncing main
@sean-simmons-progress
reverting back to arm
e6ede04 
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@sean-simmons-progress
syncing the docker version
fd6123e 
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Mar 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sean-simmons-progress sean-simmons-progress marked this pull request as ready for review March 30, 2023 17:36
@sean-simmons-progress sean-simmons-progress merged commit 02c6454 into main Mar 30, 2023
28 checks passed
@sean-simmons-progress sean-simmons-progress deleted the sean-simmons-progress/bugfix/build-docker-image branch March 30, 2023 18:15
@sean-simmons-progress sean-simmons-progress mentioned this pull request Mar 30, 2023
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnmccrae johnmccrae johnmccrae approved these changes

@PrajaktaPurohit PrajaktaPurohit Awaiting requested review from PrajaktaPurohit

@tpowell-progress tpowell-progress Awaiting requested review from tpowell-progress

@neha-p6 neha-p6 Awaiting requested review from neha-p6

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sean-simmons-progress @johnmccrae