Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix choco functional test #13861

Merged
merged 11 commits into from Jul 31, 2023
Merged

Fix choco functional test #13861

merged 11 commits into from Jul 31, 2023

Conversation

tpowell-progress
Copy link
Contributor

@tpowell-progress tpowell-progress commented Jul 28, 2023 •
edited

Description

Fix tests:

  • Use choco search -lo for v1 package lists and choco list for v2 and beyond lists.
  • Continue using choco list for v1 package lists and choco list for v2 and beyond searches

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@tpowell-progress
Only do search
4798347 
Signed-off-by: Thomas Powell <thomas.powell@progress.com>
@tpowell-progress
choco search -> list
d18e322 
Signed-off-by: Thomas Powell <thomas.powell@progress.com>
@tpowell-progress
choco list -> search and trying again
68a992c 
Signed-off-by: Thomas Powell <thomas.powell@progress.com>
@tpowell-progress
force search subcommand
cea8f86 
Signed-off-by: Thomas Powell <thomas.powell@progress.com>
@tpowell-progress tpowell-progress changed the title Tp/chef18 choco search above 14 Fix choco functional test Jul 28, 2023
@tpowell-progress tpowell-progress marked this pull request as ready for review July 28, 2023 17:32
@tpowell-progress tpowell-progress requested review from a team as code owners July 28, 2023 17:32
@tpowell-progress
choco 1/2
5ce302f 
Signed-off-by: Thomas Powell <thomas.powell@progress.com>
@tpowell-progress
Instance var set
074cad1 
Signed-off-by: Thomas Powell <thomas.powell@progress.com>
@tpowell-progress
Lint error fixes
ce5a9aa 
Signed-off-by: Thomas Powell <thomas.powell@progress.com>
@tpowell-progress
Tweaked the comment on the package spec
dcec8f9 
Signed-off-by: Thomas Powell <thomas.powell@progress.com>
@tpowell-progress
switch on v1/v2
7fe0091 
Signed-off-by: Thomas Powell <thomas.powell@progress.com>
@tpowell-progress
revert list
9de86db 
Signed-off-by: Thomas Powell <thomas.powell@progress.com>
@tpowell-progress
consistent calls
c51728a 
Signed-off-by: Thomas Powell <thomas.powell@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Jul 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tpowell-progress tpowell-progress merged commit a8f5d1e into main Jul 31, 2023
27 of 28 checks passed
@tpowell-progress tpowell-progress deleted the tp/chef18-choco-search-above-14 branch July 31, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neha-p6 neha-p6 neha-p6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tpowell-progress @neha-p6