Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RockyLinux-8 #13867

Merged
merged 7 commits into from Aug 22, 2023
Merged

Add RockyLinux-8 #13867

merged 7 commits into from Aug 22, 2023

Conversation

poorndm
Copy link
Contributor

@poorndm poorndm commented Aug 3, 2023

Description

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

poorndm and others added 7 commits August 3, 2023 13:11
@poorndm
Add RockyLinux-8
982dd3f 
Signed-off-by: poorndm <poorndm@progress.com>
@sean-simmons-progress
adding this to the container platforms
42fdd83 
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@sean-simmons-progress
syntax error
2b75244 
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@poorndm
rename the container-rockylinux
5af0685
@sean-simmons-progress
reverting to rocky-8
0d293d0 
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@poorndm
update omnibus- version to test package build format on Rocky
b76814a 
Signed-off-by: poorndm <poorndm@progress.com>
@poorndm
Revert the omnibus-temp branch and id changes
b39fd27 
Signed-off-by: poorndm <poorndm@progress.com>
@poorndm
Copy link
Contributor Author

poorndm commented Aug 17, 2023

Test Build : https://buildkite.com/chef/chef-chef-main-validate-adhoc/builds/644#018a0141-d103-446d-aafc-8f67c479ab74

@sonarcloud
Copy link

sonarcloud bot commented Aug 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@poorndm poorndm marked this pull request as ready for review August 17, 2023 04:04
@poorndm poorndm requested review from a team as code owners August 17, 2023 04:04
jaymzh
jaymzh approved these changes Aug 18, 2023
View reviewed changes
Copy link
Collaborator

@jaymzh jaymzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general. Windows is failing, but I'm assuming that's just more ffi stuff. Assuming so, someone internal can pull the trigger.

@tpowell-progress tpowell-progress merged commit 13ca197 into main Aug 22, 2023
26 of 28 checks passed
@tpowell-progress tpowell-progress deleted the poorndm/CHEF-914-Add-Rocky-8 branch August 22, 2023 19:08
@jaymzh jaymzh mentioned this pull request Aug 22, 2023
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaymzh jaymzh jaymzh approved these changes

@tpowell-progress tpowell-progress tpowell-progress approved these changes

@johnmccrae johnmccrae Awaiting requested review from johnmccrae

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@poorndm @jaymzh @tpowell-progress @sean-simmons-progress