Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated the test to be RFC2119 compliant #13926

Merged
merged 1 commit into from Sep 15, 2023
Merged

updated the test to be RFC2119 compliant #13926

merged 1 commit into from Sep 15, 2023

Conversation

johnmccrae
Copy link
Contributor

Description

The test had a malformed body element for the response object. It was causing tests to fail with new networking gems

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@johnmccrae
updated the test to be RFC 2219 compliant
eb931c2 
Signed-off-by: John McCrae <john.mccrae@progress.com>
@johnmccrae johnmccrae requested review from a team as code owners September 14, 2023 20:18
@sonarcloud
Copy link

sonarcloud bot commented Sep 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@johnmccrae johnmccrae changed the title updated the test to be RFC 2219 compliant updated the test to be RFC2119 compliant Sep 15, 2023
@johnmccrae johnmccrae merged commit 019c90c into chef-17 Sep 15, 2023
32 of 33 checks passed
@johnmccrae johnmccrae deleted the jfm/chef17-compliance-spec branch September 15, 2023 13:07
This was referenced Sep 28, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpowell-progress tpowell-progress tpowell-progress approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johnmccrae @tpowell-progress