Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix homebrew path when which() returns false #13937

Merged
merged 2 commits into from Sep 20, 2023
Merged

fix homebrew path when which() returns false #13937

merged 2 commits into from Sep 20, 2023

Conversation

Stromweld
Copy link
Contributor

Description

fix homebrew path when which() returns false

Related Issue

#13934

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@Stromweld
fix homebrew path when which() returns false
af1c39a 
fix homebrew_bin_path when which() returns false
@Stromweld Stromweld self-assigned this Sep 19, 2023
@Stromweld Stromweld requested review from a team as code owners September 19, 2023 19:56
@Stromweld
linting fixes
3221f9c 
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tpowell-progress
Copy link
Contributor

Pending CI

@tpowell-progress tpowell-progress self-assigned this Sep 19, 2023
@tpowell-progress tpowell-progress merged commit ad619fc into main Sep 20, 2023
27 of 28 checks passed
@tpowell-progress tpowell-progress deleted the Stromweld-patch-2 branch September 20, 2023 13:13
@tpowell-progress tpowell-progress mentioned this pull request Feb 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpowell-progress tpowell-progress tpowell-progress approved these changes

Assignees

@Stromweld Stromweld

@tpowell-progress tpowell-progress

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Stromweld @tpowell-progress