Chef::CookbookSynchronizer#remove_deleted_files: Use Array instead of Set #13941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpowell-progress
approved these changes
Sep 22, 2023
…f Sets Should address chef#13940 Signed-off-by: David Crosby <dcrosby@fb.com>
dafyddcrosby
force-pushed
the
13940_fix
branch
from
2939d9a
to
d93bd7d
Compare
dafyddcrosby
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
jaymzh
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Should address #13940. The usage of Sets over Arrays was only a minor speedup IIRC, and we can take another pass it once we've figured out why
.to_setwasn't working with the earlierrequire.Setbecame a built-in in Ruby 3.2, so could also wait until that's the running version before using thatSetmore extensively in the clientRelated Issue
#13940
Types of changes
Checklist: