Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chef::Log.debug the puts debugs #13970

Merged
merged 1 commit into from Sep 29, 2023
Merged

Chef::Log.debug the puts debugs #13970

merged 1 commit into from Sep 29, 2023

Conversation

tpowell-progress
Copy link
Contributor

Description

The monkey patch for net/http issues pre-Ruby 3.2 added puts statements without converting them to Chef::Log.debug

Related Issue

About Monkey patch ruby for net/http added verbosity in #13745

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@tpowell-progress
Chef::Log.debug the puts debugs
bf6e40f 
Signed-off-by: Thomas Powell <thomas.powell@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tpowell-progress tpowell-progress merged commit 659301c into main Sep 29, 2023
27 of 28 checks passed
@tpowell-progress tpowell-progress deleted the tp/issue-13936-debug-net-http branch September 29, 2023 17:44
@gene1wood
Copy link
Contributor

This is released in Chef Infra 18.4.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnmccrae johnmccrae johnmccrae approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tpowell-progress @gene1wood @johnmccrae