Adding a chocolatey installer #14043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John <john.mccrae@progress.com>
Signed-off-by: John <john.mccrae@progress.com>
tpowell-progress
approved these changes
Oct 23, 2023
jaymzh
requested changes
Oct 24, 2023
| description: "The URL to download Chocolatey from. This defaults to the value of $env:ChocolateyDownloadUrl, if it is set, and otherwise falls back to the official Chocolatey community repository to download the Chocolatey package. It can be used for offline installation by providing a path to a Chocolatey.nupkg." | ||
|
|
||
| property :chocolatey_version, String, | ||
| description: "Specifies a target version of Chocolatey to install. By default, the latest stable version is installed. This will use the value in $env:ChocolateyVersion by default, if that environment variable is present. This parameter is ignored if download_url is set." |
There was a problem hiding this comment.
Per our discussion, this is actually being used directly by the Chocolatey install.ps1 script and the environment variable can be used to redirect the standard installer to an alternate version.
tpowell-progress
requested changes
Oct 24, 2023
Signed-off-by: John <john.mccrae@progress.com>
Signed-off-by: John <john.mccrae@progress.com>
Signed-off-by: John <john.mccrae@progress.com>
Signed-off-by: John <john.mccrae@progress.com>
tpowell-progress
approved these changes
Oct 25, 2023
Signed-off-by: John <john.mccrae@progress.com>
Signed-off-by: John <john.mccrae@progress.com>
|
Kudos, SonarCloud Quality Gate passed!
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces #13603. That PR branch was borked.
This PR comes from a customer request - https://chefio.atlassian.net/browse/INFC-354
We want to provide a way, consistent with other resources, that allows for the admin to install Choco if it is not present.
The main problem here is that we have a number of resources for chocolatey users but customers attempt to use them without having choco installed already and they get weird errors. We did not correctly set customer expectations with the Choco resources that we did with other package managers. The others will typically offer and option to install that package manager if it's missing. Until now, we have not done that with Choco. This improvement corrects that by adding an installer resource for Chocolatey and improves error output to direct the customer to use the installer. We do NOT install Chocolatey for the user as that would deviate from Chef design philosophies around being absolutely transparent about or explicit about what we're doing - meaning we don't perform some action that the customer has not explicitly chosen to do : We don't install the package manager if it's missing, we inform the customer and offer the new resource to fix that issue.
Related Issue
Types of changes
Checklist:
Gemfile.lockhas changed, I have used--conservativeto do it and included the full output in the Description above.