Add missing description to windows_service load_current_resource for idempotent check to be successful

[jakauppila]

When using windows_service to create/configure Windows services, if you specify a description, it will trigger a change on every execution due to the value not being discovered in load_current_value

 

Description

Discover the Windows Service description from win-32/service output.

Related Issue

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

• I have read the CONTRIBUTING document.
• I have run the pre-merge tests locally and they pass.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
• All new and existing tests passed.
• All commits have been signed-off for the Developer Certificate of Origin.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.4% Duplication

[bdwyertech]

This is broken. ServiceConfigInfo does not include a description field, do we even test things anymore?

https://github.com/chef/win32-service/blob/67a0f7ac46a5e0332d95867f1ee2e7cd733b9117/lib/win32/service.rb#L206-L217

@tpowell-progress I would suggest reverting this or marking another version as "stable" for Windows.

[bdwyertech]

@tpowell-progress @johnmccrae this is still broken FYI. Any service on Windows using description field will error out...

[tpowell-progress]

This is broken. ServiceConfigInfo does not include a description field, do we even test things anymore?

Yes, we have added an internal UAT process which is part of the longer timeframes between releases. However, the focus of those tests are generally product driven requests. My fault for not requesting an explicit test to validate the new code, but I'm assuming that the resource continues to work without the description, or else there would be kitchen-tests that would be failing in CI.