Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chef17] backport homebrew prs #14153

Merged
merged 2 commits into from Dec 29, 2023
Merged

[chef17] backport homebrew prs #14153

merged 2 commits into from Dec 29, 2023

Conversation

johnmccrae
Copy link
Contributor

Description

Backporting PR13669 and PR13937 to fix homebrew

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

Backporting PR13669 and PR13937 to fix homebrew
7d4e3fe 
Signed-off-by: John McCrae <mccrae@progress.com>
@johnmccrae johnmccrae requested review from a team as code owners December 21, 2023 00:36
@github-actions github-actions bot added the documentation How do we use this project? label Dec 21, 2023
@johnmccrae
Refactoring to account for test-kitchen issues
86fc924 
Signed-off-by: John McCrae <john.mccrae@progress.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 29, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@johnmccrae johnmccrae merged commit 4f10910 into chef-17 Dec 29, 2023
34 of 35 checks passed
@johnmccrae johnmccrae deleted the jfm/chef17-backport-homebrew-prs branch December 29, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation How do we use this project?
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@johnmccrae