Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Train Support to allow for more connection types #14208

Merged
merged 2 commits into from Jan 29, 2024

Conversation

johnmccrae
Copy link
Contributor

@johnmccrae johnmccrae commented Jan 29, 2024

Description

This is a rebuild of #13534. The underlying branch was deleted somehow?

These changes supported protocols for knife bootstrap to dynamic detection of installed Train transports instead of just static ssh and winrm.

With this, alternative connection options such as AWS Systems Manager, Telnet, Serial/USB, and others get viable for easy onboarding of Chef nodes.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@johnmccrae johnmccrae requested review from a team as code owners January 29, 2024 15:35
Signed-off-by: John McCrae <john.mccrae@progress.com>
@johnmccrae johnmccrae force-pushed the jfm/chef17-knife-train-update3 branch from e00627c to 2ae212a Compare January 29, 2024 15:42
Signed-off-by: John McCrae <john.mccrae@progress.com>
Copy link

sonarcloud bot commented Jan 29, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@johnmccrae johnmccrae merged commit 9259d57 into chef-17 Jan 29, 2024
34 of 35 checks passed
@johnmccrae johnmccrae deleted the jfm/chef17-knife-train-update3 branch January 29, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants