Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix kitchen-tests #14280

Merged
merged 12 commits into from Mar 25, 2024
Merged

fix kitchen-tests #14280

merged 12 commits into from Mar 25, 2024

Conversation

Stromweld
Copy link
Contributor

Description

This allows for easy testing with test-kitchen of latest version of chef-client in current channel

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@Stromweld Stromweld requested review from a team as code owners March 8, 2024 17:41
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@Stromweld Stromweld marked this pull request as draft March 8, 2024 22:34
@github-actions github-actions bot added documentation How do we use this project? and removed documentation How do we use this project? labels Mar 9, 2024
@Stromweld
Copy link
Contributor Author

I think this is ready for iteration 1 of the updates. Additional work is noted in comments within code and kitchen.yml workflow builds.

@Stromweld Stromweld marked this pull request as ready for review March 13, 2024 14:22
@johnmccrae
Copy link
Contributor

Hi, can you please squash your commits here?

Copy link
Contributor

@johnmccrae johnmccrae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give this a go once the commits are squashed

@Stromweld
Copy link
Contributor Author

@johnmccrae on the merge button drop down you can also select squash merge that squashes the commits.

Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Copy link
Contributor

@tpowell-progress tpowell-progress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move the ifconfig logic

Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Copy link

sonarcloud bot commented Mar 20, 2024

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@johnmccrae johnmccrae merged commit f20f727 into main Mar 25, 2024
54 checks passed
@johnmccrae johnmccrae deleted the fix-kitche-tests branch March 25, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants