Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the issue with log level on the chef config #14294

Merged
merged 3 commits into from Mar 27, 2024

Conversation

ashiqueps
Copy link
Contributor

@ashiqueps ashiqueps commented Mar 26, 2024

Description

In the chef config, there are two different options to set the log level. One is the log_level and the other is the verbose. The verbose has more preference, meaning that if it is set, it will overwrite the log_level based on the verbosity level.

Currently, If the verbosity is not set, the code will default the log_level to warn even if the user specifies a different log_level on the config.rb or the credentials file.

This PR will update that flow so that, if the verbosity is not set, it will use whatever value is already set on the log_level and if that is :auto(the default value), it will default to warn.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

Signed-off-by: Ashique Saidalavi <Ashique.saidalavi@progress.com>
@ashiqueps ashiqueps requested review from a team as code owners March 26, 2024 07:54
Signed-off-by: Ashique Saidalavi <Ashique.saidalavi@progress.com>
@johnmccrae
Copy link
Contributor

@nikhil2611 can you take another look at the specs, there are still failures

Copy link
Contributor

@johnmccrae johnmccrae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please check the testers again, there are still failures. Cheers

@tpowell-progress tpowell-progress self-assigned this Mar 26, 2024
@tpowell-progress tpowell-progress added the Status: Waiting on Contributor A pull request that has unresolved requested actions from the author. label Mar 26, 2024
@nikhil2611 nikhil2611 self-requested a review March 27, 2024 06:26
Signed-off-by: Ashique Saidalavi <Ashique.saidalavi@progress.com>
Copy link

sonarcloud bot commented Mar 27, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@johnmccrae johnmccrae merged commit 5e5fe79 into main Mar 27, 2024
58 checks passed
@johnmccrae johnmccrae deleted the CHEF-652-knife-log-level branch March 27, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Waiting on Contributor A pull request that has unresolved requested actions from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants