[FileCache#Find] N to 1 calls for regex matching #14351
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dafyddcrosby
force-pushed
the
filecache_find_dirglob
branch
from
76490a7
to
0acda49
Compare
dafyddcrosby
changed the title
dafyddcrosby
force-pushed
the
filecache_find_dirglob
branch
from
0acda49
to
4093aac
Compare
Signed-off-by: David Crosby <dcrosby@fb.com>
dafyddcrosby
force-pushed
the
filecache_find_dirglob
branch
from
4093aac
to
d65551e
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This moves pre-computable values from the inner loop of
#findto outside of the loop.Types of changes
Checklist:
Gemfile.lockhas changed, I have used--conservativeto do it and included the full output in the Description above.