Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PathHelper#join] Reduce allocations #14385

Merged
merged 1 commit into from
May 28, 2024
Merged

[PathHelper#join] Reduce allocations #14385

merged 1 commit into from
May 28, 2024

Conversation

dafyddcrosby
Copy link
Contributor

Description

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@dafyddcrosby
[PathHelper#join] Reduce allocations
2043039 
Signed-off-by: David Crosby <dcrosby@fb.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dafyddcrosby dafyddcrosby marked this pull request as ready for review May 21, 2024 20:11
@dafyddcrosby dafyddcrosby requested review from a team as code owners May 21, 2024 20:11
@tpowell-progress tpowell-progress self-assigned this May 28, 2024
@tpowell-progress tpowell-progress merged commit c7cb94b into chef:main May 28, 2024
53 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpowell-progress tpowell-progress tpowell-progress approved these changes

Assignees

@tpowell-progress tpowell-progress

Labels
Chef 18.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dafyddcrosby @tpowell-progress