deprecate method_missing in cheffish merged_config #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typical "method_missing is terrible" reasons... Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
since this is a very base library object i don't want to use the chef logger and do not want to introduce a dep on chef itself (as a circular dep that is just going to cause endless pain and suffering). its very likely that any WARNs emitted by this will be internal to our own chef-org codebase anyway. |
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
The only WARNs i got in chef-provisioning-fog for this were caused entirely by a very twisty rabbit hole caused entirely by #130 and will be gone once that is fixed. None of the code in that repo deliberately used this method_missing API. The fact that method_missing masked a bug is another good reason why it needs to go away. |
thommay
approved these changes
Oct 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typical "method_missing is terrible" reasons...