Make knife references backward-compatible #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Versions of chef starting at 17.0.178 do not include the knife gem so we can't require it unconditionally. This also modifies load_chef_config to use Chef::WorkstationConfigLoader for chef 12+ instead of Knife::chef_config_dir; this is available in 12+ and avoids having to further split behavior on version such as <12 = knife.locate_config_file, <17 = knife.chef_config_file , 17+ config loader. Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
marcparadise
force-pushed
the
mp/knife-compat
branch
from
a649f31
to
8aa7402
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Versions of chef starting at 17.0.178 do not include the knife gem
so we can't require it unconditionally.
This also modifies load_chef_config to use Chef::WorkstationConfigLoader for chef 12+ instead of
Knife::chef_config_dir; this is available in 12+ and avoids having to further split behavior on version such as <12 =knife.locate_config_file, <17 =knife.chef_config_file, 17+ config loader.Signed-off-by: Marc A. Paradise marc.paradise@gmail.com