Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update FileSystem.copy_to #220

Merged
merged 1 commit into from
Jan 3, 2023
Merged

Update FileSystem.copy_to #220

merged 1 commit into from
Jan 3, 2023

Conversation

vinay-satish
Copy link
Contributor

@vinay-satish vinay-satish commented Dec 8, 2022 •
edited
Loading

Signed-off-by: Vinay Satish vinay.satish@progress.com

Description

Related to - chef/chef#13107

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@vinay-satish vinay-satish requested review from a team as code owners December 8, 2022 11:23
marcparadise
marcparadise reviewed Dec 12, 2022
View reviewed changes
Copy link
Member

@marcparadise marcparadise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide reference in the commit message to the PR/branch that requires this change.

@lbakerchef
Copy link

There are a lot of failing checks, and for some reason verify is not reporting.

@lbakerchef
Copy link

Can we see this working somehow?

@vinay-satish
Update FileSystem.copy_to
84a6a13 
Signed-off-by: Vinay Satish <vinay.satish@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Dec 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@PrajaktaPurohit PrajaktaPurohit merged commit 4e9ee82 into chef:main Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcparadise marcparadise marcparadise approved these changes

@lbakerchef lbakerchef lbakerchef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vinay-satish @lbakerchef @marcparadise @PrajaktaPurohit