Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use appropriate function call for chef 12 #33

Merged
merged 1 commit into from
Jan 27, 2015
Merged

Use appropriate function call for chef 12 #33

merged 1 commit into from
Jan 27, 2015

Conversation

elliott-davis
Copy link

In chef12 the function locate_config_file in Chef::Knife was renamed
to chef_config_dir. This patch adds a conditional to check for chef12
and apply the appropriate function call.

@someara
Copy link

someara commented Jan 19, 2015

looks good to me

@jjasghar
Copy link

👍
selfie-0

@smurawski
Copy link

@jkeiser How's this looking, anything blocking a review?

@jkeiser
Copy link
Contributor

jkeiser commented Jan 20, 2015

The code itself looks good, but:

  • Why are the 1.9.3 tests being removed? We are trying to support the same versions as Chef, and AFAIK we haven't dropped support for it (I could be wrong, happy to be :)
  • Is GreenAndSecure included with Chef? It looks like a plugin ... perhaps it's better to use Chef::VERSION so it'll run everywhere.

@elliott-davis
Copy link
Author

The problem I was seeing with the 1.9.3 test was:

Gem::InstallError: ohai requires Ruby version >= 2.0.0.

https://github.com/chef/ohai/blob/master/ohai.gemspec#L16

In chef12 the function locate_config_file in Chef::Knife was renamed
to chef_config_dir.  This patch adds a conditional to check for chef12
and apply the appropriate function call.
@jkeiser jkeiser added this to the 1.0 milestone Jan 26, 2015
@jkeiser
Copy link
Contributor

jkeiser commented Jan 27, 2015

OK. Will merge and update travis to not run 1.9.3 anymore. Thanks :)

@jkeiser jkeiser merged commit fe71797 into chef:master Jan 27, 2015
@thommay thommay added Bug Type: Bug Does not work as expected. and removed Bug labels Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Does not work as expected.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants