Use correct user-association endpoint for Chef 12

[stevendanna]

The correct endpoint for user-association is:

POST /organizations/ORGNAME/users

The API currently being made will be rejected with a 405 Method Not
Allowed error.

[stevendanna]

Tests are failing as expected. I think to completely fix them we likely need some changes in chef-zero as well. Getting chef-zero in line with Chef Server 12 was started here:

chef/chef-zero#117

[tyler-ball]

Can you update https://github.com/chef/cheffish/blob/master/spec/integration/chef_organization_spec.rb to add testing for this? If chef-zero is updated it will no longer throw a 405 but I would expect the specs that test this functionality to fail.

This is also a breaking change for old versions of chef-server, correct? So this would either need to be released as a major version or it would need to be updated to support both CS11 and CS12.

[tyler-ball]

It looks like the integration tests only test against Chef Server 12. Do we even care about supporting Chef Server 11?

[stevendanna]

Do we even care about supporting Chef Server 11?

Chef Server 11 is supported until Chef Server 13 comes out. In my opinion all API clients we maintain should support both.

[tyler-ball]

I'm going to mark this as blocked because it depends on chef/chef-zero#117

[tyler-ball]

@stevendanna I just force pushed this. There is still 1 test failing so I'm going to troubleshoot that next.

[tyler-ball]

  1) Chef::Resource::ChefOrganization When the Chef server is in multi-org mode and chef_server_url is pointed at /organizations/foo and already has an organization named x invites and membership tests chef_organization "x" upgrades invites to members when asked
     Failure/Error: expect(get('/organizations/x/association_requests').map { |u| u['username'] }).to eq(%w(invited2))

       expected: ["invited2"]
            got: ["invited", "invited2"]

       (compared using ==)
     # ./spec/integration/chef_organization_spec.rb:152:in `block (6 levels) in <top (required)>'

[jkeiser]

@tyler-ball this change looks good assuming the endpoint is the way it looks. Is the above test failure actually caused by this change?

[tyler-ball]

@jkeiser yes - the failures were different before this change.

[jkeiser]

Yeah, it looks like that is likely a chef-zero issue: if you do the POST thing to add a user to an org, it should remove any association requests as well.