A handful of fixes to make the Cheffish matrix pass on all the relevant Chef versions. #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -15,7 +16,8 @@ env: | |||
| - CHEF_VERSION=12.4.1 | |||
| - CHEF_VERSION=12.3.0 | |||
| - CHEF_VERSION=12.2.1 | |||
| - CHEF_VERSION=12.1.2 | |||
| # - CHEF_VERSION=12.2.0 | |||
| # - CHEF_VERSION=12.1.2 # known broken for now. | |||
There was a problem hiding this comment.
Did the allow_failures block not work for these? I would think we still want it testing and showing up as failures (unless its taking a lot of time or something)
There was a problem hiding this comment.
I'll clean that up: I'm thinking we don't need 12.2.0 if we've got 12.2.1, and 12.1.2 is broken but we can run it anyway. I'll also re-add Ruby versions to test against.
|
I have 1 question but 👍 and feel free to merge after answering that |
added 3 commits
August 24, 2015 14:14
- Add .rspec, add chef-client-versions.gemfile.lock to .gitignore.
…ith Chef < 12.4.
…to us (e.g. for have_updated).
| # - 2.0.0 | ||
| # - 2.1.1 | ||
| - 2.1.2 | ||
| - 2.0.0 |
There was a problem hiding this comment.
Not required for this checkin; but if you just say 2.0 and 2.1, I think Travis will pick the latest.
|
👍 |
randomcamel
added a commit
that referenced
this pull request
Aug 24, 2015
A handful of fixes to make the Cheffish matrix pass on all the relevant Chef versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.