Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move provider code into resources #93

Merged
merged 3 commits into from
Oct 29, 2015
Merged

Move provider code into resources #93

merged 3 commits into from
Oct 29, 2015

Conversation

jkeiser
Copy link
Contributor

@jkeiser jkeiser commented Oct 29, 2015

This is a strictly verbatim move, moving all helper methods into action_class.class_eval blocks. Refactoring is for later.


module Cheffish
class BaseResource < ChefCompat::Resource
declare_action_class.class_eval do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a difference between action_class and declare_action_class?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

action_class only works if there is already an action class. declare_action_class will make sure there is one. An action class will already be there if you are a subclass of something with an action class, or if you declare action.

@tyler-ball
Copy link
Contributor

👍

@jkeiser jkeiser merged commit 02ca057 into master Oct 29, 2015
@tyler-ball tyler-ball deleted the jk/no_providers branch November 9, 2015 22:19
@thommay thommay added Improvement Type: Enhancement Adds new functionality. and removed Improvement labels Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Adds new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants