Change Ruby Target to 2.3 #37
Conversation
This is what ships in ChefDK 1.x, Chef Client 12.x, and 13.0 It can be moved up again to 2.4 once all stable chef products move up to 2.4 Signed-off-by: Aaron Kalin <akalin@martinisoftware.com>
It can be pretty noisy right off the bat and a design goal for later Signed-off-by: Aaron Kalin <akalin@martinisoftware.com>
|
I added a new commit to also disable the style cop that gets enabled with this new target. |
|
We still can't bump this until all Chef 12 is EoL. Chef 12 on windows shipped with 2.0 and *nix had 2.1 until pretty recently. This would break all those users. It's very much on our mind though and something we'll do with the release of ChefDK 3.0/ Chef 14 |
|
see #19 (comment) this can only be accepted when chef < 12.14.x support is dropped from community cookbooks. |
|
I'm gonna bring this back up again for inclusion since we're nearing ChefDK 3 which is Chef13+ I can re-submit an updated PR again if you like |
|
It would be great to do this at this point. I was planning to get a rubocop bump into cookstyle as well and then release the new major version in the next DK |
|
Yep, now's the time! 👍 |
This is what ships in ChefDK 1.x, Chef Client 12.x, and 13.0
It can be moved up again to 2.4 once all stable chef products move up to 2.4
Part of the motivation here is to use some new Ruby style features, specifically a new heredoc syntax in 2.3 which uses a tilde to denote automatic whitespace trimming.
One of the cops that becomes enabled by this target change is
Style/FrozenStringLiteralCommentwhich can be disabled for the time being I think.